search

diagrams / diagrams-haddock

Preprocessor for including inline diagrams in Haddock documentation
Other
10 stars 4 forks source link

0.3.0.8: src/Diagrams/Haddock.hs:458:55: Couldn't match expected type #26

Closed juhp closed 8 years ago

juhp commented 8 years ago

diagrams-haddock-0.3.0.8 failed to build in Stackage Nightly:

src/Diagrams/Haddock.hs:458:55:
    Couldn't match expected type ‘[t0]
                                  -> Bool -> Options SVG V2 Double’
                with actual type ‘Options SVG V2 Double’
    The function ‘SVGOptions’ is applied to five arguments,
    but its type ‘Diagrams.Size.SizeSpec V2 Double
                  -> Maybe diagrams-svg-1.3.1.7:Graphics.Rendering.SVG.SvgM
                  -> Data.Text.Internal.Text
                  -> Options SVG V2 Double’
    has only three
    In the third argument of ‘DB.mkBuildOpts’, namely
      ‘(SVGOptions (mkSizeSpec2D w h) Nothing "" [] False)’
    In the first argument of ‘(&)’, namely
      ‘DB.mkBuildOpts
         SVG zero (SVGOptions (mkSizeSpec2D w h) Nothing "" [] False)’
byorgey commented 8 years ago

@bergey , do you know what's going on here?

byorgey commented 8 years ago

Oh, I see what happened, it looks like the 1.3.1.8 release accidentally got cut from the master branch instead of from the release branch, so it included some stuff it should not have. I'll take care of it.

byorgey commented 8 years ago

Sorry, I wrote that too fast. Let me be more precise. It looks like what happened is:

byorgey commented 8 years ago

Another confounding issue: it seems that the latest changes on diagrams-svg master REQUIRE lucid-svg-0.6.

jeffreyrosenbluth commented 8 years ago

This is my fault, I tried to squeeze in the update to lucid-svg 0.6 to fix a bug, but was too hasty. Let me know what you think should be done from hear and I'll take care of it. Sorry about that

On Mon, Nov 16, 2015 at 5:06 PM Brent Yorgey notifications@github.com wrote:

Another confounding issue: it seems that the latest changes on diagrams-svg master REQUIRE lucid-svg-0.6.

— Reply to this email directly or view it on GitHub https://github.com/diagrams/diagrams-haddock/issues/26#issuecomment-157186508 .

bergey commented 8 years ago

I obviously released without enough testing also. I should have time to look at this tomorrow morning.

byorgey commented 8 years ago

Will the previous release of diagrams-svg (before the options updates) compile with lucid-svg-0.6?

By the way, for the moment I deprecated diagrams-svg-1.3.1.8, since it would cause any builds with stack to fail. That puts us back in the situation where diagrams-haddock fails with a type error; at least that is not installed by default with diagrams so it has less of an immediate impact.

On Mon, Nov 16, 2015 at 7:46 PM Daniel Bergey notifications@github.com wrote:

I obviously released without enough testing also. I should have time to look at this tomorrow morning.

— Reply to this email directly or view it on GitHub https://github.com/diagrams/diagrams-haddock/issues/26#issuecomment-157234724 .

jeffreyrosenbluth commented 8 years ago

Yes, I believe so, the change to lucid-svg was restricted to the textPath function which we don't use in diagrams.

byorgey commented 8 years ago

OK, in that case I think the thing to do is to simply bump the upper bound on lucid-svg in diagrams-svg (supporting both 0.5 and 0.6 if we can), and release diagrams-svg-1.3.1.9 from the release branch, and then make a corresponding release of diagrams-haddock-0.3.0.9 also from the release branch (which I just created). Unless there is something that I am missing.

byorgey commented 8 years ago

We should probably also mark diagrams-haddock-0.3.0.8 as deprecated on Hackage.

jeffreyrosenbluth commented 8 years ago

Sounds good, I'll try to get to this today.

On Wed, Nov 18, 2015 at 10:33 PM Brent Yorgey notifications@github.com wrote:

We should probably also mark diagrams-haddock-0.3.0.8 as deprecated on Hackage.

— Reply to this email directly or view it on GitHub https://github.com/diagrams/diagrams-haddock/issues/26#issuecomment-157940179 .

byorgey commented 8 years ago

Thanks @jeffreyrosenbluth . @juhp, it looks like everything is building again (http://gondor.cs.hendrix.edu:8080/job/Diagrams%20HEAD/21/ ). Let us know if you see any other build failures from stackage.