search

diagrams / diagrams-lib

Diagrams standard library
https://diagrams.github.io/
Other
138 stars 62 forks source link

Add Serialize instances for Trail, Path, Located #271

Closed sid-kap closed 8 years ago

sid-kap commented 8 years ago

Related to timbod7/haskell-chart#112

sid-kap commented 8 years ago

It looks like the test failed with the following error:

arc end point is at radius 1 in the ending direction:     tests: out of memory (requested 1048576 bytes)

Has anyone seen this error before? I don't see how my changes would have caused this error.

sid-kap commented 8 years ago

By the way, I noticed that on my machine, both times that I tried running it, stack test takes up 93% of my computer's memory and freezes my computer, while stack test --jobs=1 runs in about 10 seconds and doesn't freeze my computer. Maybe something similar is going on here?

(I got the suggestion of running --jobs=1 from here: https://github.com/commercialhaskell/stack/blob/master/doc/faq.md#my-tests-are-failing-what-should-i-do)

bergey commented 8 years ago

That's CI failure is due to my changes. I'll debug it, but it need not hold up merging this.

Are there other changes you want to make, or is this ready to merge?

sid-kap commented 8 years ago

No, I don't plan to make any more changes. Would you like me to squash the commits?

bergey commented 8 years ago

No need, thanks.

sid-kap commented 8 years ago

Thanks!