search

diagrams / diagrams-lib

Diagrams standard library
https://diagrams.github.io/
Other
138 stars 62 forks source link

Added API loadImageEmbBS, a pure version of loadImageEmb #292

Closed dfordivam closed 7 years ago

dfordivam commented 7 years ago

Fixes #291

mention-bot commented 7 years ago

@dfordivam, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cchalmers, @jeffreyrosenbluth and @byorgey to be potential reviewers.

cchalmers commented 7 years ago

Looks good to me.

While we're at it should we also add a embededImage :: Num n => DynamicImage -> DImage n Embedded function? It's still kinda annoying to do it manually. As a bonus loadImageEmb(BS) would simply become fmap embeddedImage <$> readImage path and embeddedImage <$> decodeImage bs.

cchalmers commented 7 years ago

Great, thanks! The build errors are unrelated.