search

diagrams / diagrams-lib

Diagrams standard library
https://diagrams.github.io/
Other
138 stars 62 forks source link

Relax bounds, add conditional dependency on fail #347

Closed phadej closed 5 years ago

phadej commented 5 years ago
phadej commented 5 years ago

The build fails because it's using unreleased active-0.3. I don't know what to do here

phadej commented 5 years ago 
commit f4d819a65c94e701772308a15116742b2554262e
Author: Brent Yorgey <byorgey@gmail.com>
Date:   Sat Jul 29 19:17:40 2017 -0500

    complete rewrite of active library

    This version is, I hope, much easier to use and much more
    fundamentally, semantically sound than the previous version.

is for active-0.3 which is unreleased. And indeed changes the API so much, that it's not a straightforward Data.Active -> Active module name change.

Is there way to make CI not use active master branch?

byorgey commented 5 years ago

Indeed, active master is a complete rewrite. At the time that I pulled the trigger and put that on master, I was planning to port diagrams-lib over at the same time, but the process got snagged on something and now we are in this unfortunate state. I don't remember if there is a way to tell CI for diagrams-lib which branch of active to use, let me look into it.

byorgey commented 5 years ago

Thanks! I'm going to merge this anyway, and will look into getting CI to build as a separate issue.

byorgey commented 5 years ago

By the way, the issue with CI was that we have a HEAD_DEPS variable that specifies which dependencies should be fetched from github rather than Hackage, to facilitate CI when we make breaking changes to several packages in concert. active was in the list, but clearly shouldn't be right now.