Create a library and add various options

diagrams / diagrams-pandoc

A pandoc filter to express diagrams inline using the haskell EDSL diagrams.

BSD 3-Clause "New" or "Revised" License

37 stars 9 forks source link

Create a library and add various options #2

Closed cdupont closed 8 years ago

cdupont commented 9 years ago

added library in cabal file
added attribute "echo=Above|Below" to get a display of the code
added tests

cchalmers commented 9 years ago

This is great, nice to see this getting some attention. Couple of small things:

I personally prefer diagram to diagrams to mark code blocks
I'd be nice if Above/Below didn't have to be capitalised.

Otherwise this looks good.

I don't know if you noticed there's another PR #1 (which I started in December?!, I need to start finishing off my PRs) that has extra features and was pretty much ready to merge, but depends on a branch of diagrams-builder that never got finished. It's well commented if you wanted to look at it for ideas.

bergey commented 9 years ago

@cchalmers: I advised @cdupont that last I heard you weren't planning to finish the diagrams-builder PR, and hence, #1 wasn't likely to get merged. I'm still happy to revisit it. Certainly we need some story for multiple Backends.

I'll try to get through this in the next week, but probably not before Friday.

cdupont commented 9 years ago

@cchalmers: I renamed diagram to diagrams because that matched better the name of the tool. There might be other platforms generating diagrams :) Regarding the capitalization, I'll fix that.

bergey commented 8 years ago

@cdupont What's your use-case for the library? I'm happy to split the library part from the executable, it just hadn't occurred to me that anyone would want this.

bergey commented 8 years ago

I cherry-picked most of the changes, while preserving the command-line parsing and the existing recognized classes.

In particular, I included these changes:

[X] build with latest versions of all dependencies
[X] split library from executable
[X] parse attrs for choice of echo location
[X] tests

Thank you for this PR.