search

diagrams / diagrams-rasterific

Rasterific backend for diagrams
Other
15 stars 12 forks source link

Generalise float #26

Closed cchalmers closed 9 years ago

cchalmers commented 9 years ago

Generalise Float to TypeableFloat. I've changed N Rasterific to Double to make it consistent with the other backends.

I've also taken the quality parameter from renderRasterific because it didn't seem necessary. They default jpeg quality it now 80.

byorgey commented 9 years ago

Looks good to me. If we merge this then perhaps we should also revert the changes to -doc to replace Double by N B everywhere. It's more general, yes, but also more confusing for people reading the documentation.

jeffreyrosenbluth commented 9 years ago

LGTM as well. I think we should in fact change the N Bs back to Double