Final 1.x changes - Githubissues

dialect-app / dialect

A translation app for GNOME.

https://dialectapp.org/

GNU General Public License v3.0

597 stars 69 forks source link

Final 1.x changes #187

Closed rafaelmardojai closed 3 years ago

rafaelmardojai commented 3 years ago

[x] Add the final accels to the Shortcuts Window.

rafaelmardojai commented 3 years ago

Show Pronunciation and Clear are the only actions left. Should we also add accels for those? Suggestions?

rafaelmardojai commented 3 years ago

Current accels for further discussion:

Back and Forward are standard (Alt+← Alt+→).
Paste: Ctrl + Shift + V
Copy: Ctrl + Shift + C
Listen src text: Ctrl + Alt + L
Listen dest text: Ctrl + L

mufeedali commented 3 years ago

Show Pronunciation and Clear are the only actions left. Should we also add accels for those? Suggestions?

Ctrl + P and Ctrl + D maybe?

Paste: Ctrl + Shift + V

No need to document this one i think, because the default focus is on src_text. Only reason I left the paste button there is because I felt it might be convenient for touch users. So maybe keep the shortcut but not document it?

Looks good otherwise

rafaelmardojai commented 3 years ago

Ctrl + P and Ctrl + D maybe?

Done.

Ideas for the Shortcuts Window? Should I add all the actions to the General group? Or how we better structure the actions?

mufeedali commented 3 years ago

I have some cleanup work locally, separate from the work in this MR. I want to push it, but I also want to test some stuff, so it might be a bit later (college has been annoying :sweat_smile: ). If you want to, you can just merge this, it looks good as is.