search

dialect-app / dialect

A translation app for GNOME.
https://dialectapp.org/
GNU General Public License v3.0
597 stars 69 forks source link

On phosh, no way to close the preferences dialog #255

Closed azmeuk closed 2 years ago

azmeuk commented 2 years ago

On a Librem5 with the phosh compositor, there is no way to close the dialect preferences dialog.

I am not sure whose responsibility it is though.

dialect

rafaelmardojai commented 2 years ago

Definitely libhandy/GTK3 fault, probably related to #90.

azmeuk commented 2 years ago

Ok. I just opened a ticket on the purism gitlab. Hopefully they can help.

https://source.puri.sm/Librem5/OS-issues/-/issues/264

mufeedali commented 2 years ago

Should be fixed with the new release.

azmeuk commented 2 years ago

Hi. I just installed 2.0.1 with flatpak, and this issue is still valid, maybe it worth reopening it?

2022-07-17-182435 .

azmeuk commented 2 years ago

@fushinari the issue is still valid with 2.0.2

rafaelmardojai commented 2 years ago

@azmeuk the window fits well, so I will say that the compositor isn't maximizing the window for some reason.

azmeuk commented 2 years ago

The lack of vertical maximizing is one thing, but I can live with that. However the issue reported in this ticket was that there is no way to close the preference window.

rafaelmardojai commented 2 years ago

So definitely a phosh or libadwaita issue. We only construct a AdwPreferencesWindow, so we don't touch the headerbar. Maybe your compositor is removing the button because the window has the modal property se to true.

Could you verify if other apps using AdwPreferencesWindow have the same issue?

azmeuk commented 2 years ago

I already have met (and reported) this issue somewhere else, but I cannot remember where. Anyway this seems to be an issue on the phosh side. Thank you for your help!