dialect-app / dialect

A translation app for GNOME.
GNU General Public License v3.0
596 stars 69 forks source link

Implement new Providers model #292

Closed rafaelmardojai closed 1 year ago

rafaelmardojai commented 1 year ago

User-facing changes

Main core changes

TODO

rafaelmardojai commented 1 year ago

Current engine/feature status:

I think we will implement the different engines per feature when we implement some consumer. That way we don't make unnecessary work.

rafaelmardojai commented 1 year ago

Open questions for discussion before merging:

@fushinari

mufeedali commented 1 year ago

image

Something is broken.

Regarding type annotation, I agree that we should be using it wherever possible. And about callbacks, wherever possible, we can have user-readable comments that still give us enough info to work with. For example: "window: Main Window (DialectApplicationWindow) -> Translate Button (translate_btn)"

rafaelmardojai commented 1 year ago

Something is broken.

Fixed, I was doing a really dumb thing there 😅

mufeedali commented 1 year ago

Looks good at first look, i'll be testing it once I get home today.

rafaelmardojai commented 1 year ago

The search provider has been updated. Should be ready to merge.

@fushinari Could you test if there's any major regression? If all is OK, I think we can merge and keep testing it on master branch.

mufeedali commented 1 year ago

There was a bug in the search provider but I've fixed it now. I couldn't notice any other regression in my testing.

As for my other commit, it's a fix for the "--text" parameter not working for LibreTranslate and Lingva. I found out that this is due to the language list not being loaded yet. Due to our asynchronous style of loading, the most reliable way for us seems to be the notify::visible-child-name signal and I've used the same.