Closed rafaelmardojai closed 1 year ago
Current engine/feature status:
I think we will implement the different engines per feature when we implement some consumer. That way we don't make unnecessary work.
Open questions for discussion before merging:
providers/base
I'm using python type annotation so we have some kind of documentation when implementing new providers. Should we start using it everywhere to improve code understanding for possible contributors?@Gtk.Template.Callback()
. I'm using it on new code, but pieces of code moved in the refactoring are using the old way. If we decide to use it when possible, lets add some good comments in the callbacks definitions so it's clear from were that code is run.@fushinari
Something is broken.
Regarding type annotation, I agree that we should be using it wherever possible. And about callbacks, wherever possible, we can have user-readable comments that still give us enough info to work with. For example: "window: Main Window (DialectApplicationWindow) -> Translate Button (translate_btn)"
Something is broken.
Fixed, I was doing a really dumb thing there 😅
Looks good at first look, i'll be testing it once I get home today.
The search provider has been updated. Should be ready to merge.
@fushinari Could you test if there's any major regression? If all is OK, I think we can merge and keep testing it on master branch.
There was a bug in the search provider but I've fixed it now. I couldn't notice any other regression in my testing.
As for my other commit, it's a fix for the "--text" parameter not working for LibreTranslate and Lingva. I found out that this is due to the language list not being loaded yet. Due to our asynchronous style of loading, the most reliable way for us seems to be the notify::visible-child-name signal and I've used the same.
User-facing changes
Main core changes
format_
methods now returnSoup.Message
, giving more control of the request to the provider implementationget_
methods now receive the data asbytes
, giving more control on how to deal with the dataGio.ListModel
to improve our data that interacts with widgetsTODO
NO GOD! PLEASE NO!!! NOOOOOOOOOO
self.translator.languages
.