dialect-app / dialect

A translation app for GNOME.
GNU General Public License v3.0
596 stars 69 forks source link

Use Python type annotations #311

Open rafaelmardojai opened 1 year ago

rafaelmardojai commented 1 year ago

Updated a few modules to use python type annotations so we can establish our criteria on how/where to use them.

rafaelmardojai commented 1 year ago

@fushinari With these modules updated I think we can discuss what we want in the regard of type annotations

mufeedali commented 1 year ago

Anything with a non-default type or variable type (as in str | None for example) should be annotated I think.

mufeedali commented 1 year ago

Also... what do you say to using something like Black?

rafaelmardojai commented 1 year ago

Also... what do you say to using something like Black?

Looks nice. To be honest formatting can become a headache easily, and is very common to fell on inconsistencies along the time.