dialect-app / dialect

A translation app for GNOME.
GNU General Public License v3.0
596 stars 69 forks source link

Update gettext code to use two catalogues for language names and UI #328

Closed rafaelmardojai closed 1 year ago

rafaelmardojai commented 1 year ago

Other complementary changes:

Depends on https://github.com/dialect-app/po/pull/16.

rafaelmardojai commented 1 year ago

@mufeedali Hey, merged the new structure on po (https://github.com/dialect-app/po/pull/16).

Tested this (installing the flatpak locally) and seems to be working fine, could you test it too? :p

mufeedali commented 1 year ago

image

Hmm... Passing LANG=ar to simulate an Arabic setup, I cant see the translations for anything other than the languages.

rafaelmardojai commented 1 year ago

Hmm... Passing LANG=ar to simulate an Arabic setup, I cant see the translations for anything other than the languages.

Discovered something funny.

if I run LANG=es flatpak run app.drey.Dialect.Devel I have the same issue as you. But f I just run flatpak run app.drey.Dialect.Devel (my system locale is spanish) I get the translations just right.

mufeedali commented 1 year ago

Wow, that is interesting... then what would be the correct way to set per-app locale?

rafaelmardojai commented 1 year ago

Wow, that is interesting... then what would be the correct way to set per-app locale?

Not sure. The thing is that it only works if I use LANG=es_PE.UTF-8.

But in the other hand is pretty strange that it gets the langs names right.

rafaelmardojai commented 1 year ago

So changed my system language to Portuguese and the issue happens.

rafaelmardojai commented 1 year ago

Tested again using the LANGUAGE env var and everything works fine.

mufeedali commented 1 year ago

Okay, looks good. Thanks for confirming!