search

dialect-app / dialect

A translation app for GNOME.
https://dialectapp.org/
GNU General Public License v3.0
599 stars 69 forks source link

Translation into recent languages in overview (Search provider) #56

Closed nexeleriot closed 3 years ago

nexeleriot commented 3 years ago

This would be a good feature. I started making it in my fork and I've got progress

Снимок экрана от 2020-10-17 22-49-53

nexeleriot commented 3 years ago

I didn't add it to meson yet (because i have never used it before). I used a script to install it

mufeedali commented 3 years ago

That's an amazing idea! It definitely has to be optional due to concerns like API abuse just like Live Translation, unnecessary bandwidth usage, privacy by default, etc but yes, seems very useful! I have something similar in my KRunner (based on Dialect's translation code, but with source language always on auto and destination language always on English) and it does come in handy. So I'd be interested in a PR.

nexeleriot commented 3 years ago

I think I'll add some more features and make a PR tomorrow 👍

rafaelmardojai commented 3 years ago

Awesome!

It definitely has to be optional due to concerns like API abuse just like Live Translation, unnecessary bandwidth usage, privacy by default, etc

I think GNOME disable by default new apps search providers.

mufeedali commented 3 years ago

I think GNOME disable by default new apps search providers.

Really? I think I remember Lollypop's search as being enabled by default. Maybe I'm just misremembering though.

nexeleriot commented 3 years ago

No, they are enabled by default. Maybe we can disable dialect provider using Gio.Settings in postinstall script

rafaelmardojai commented 3 years ago

For some reason are disabled by default for me. 😂

mufeedali commented 3 years ago

No, they are enabled by default. Maybe we can disable dialect provider using Gio.Settings in postinstall script

Is there a way to give an option within the UI?

nexeleriot commented 3 years ago

Yes, using the same Gio.Settings

nexeleriot commented 3 years ago

Ok, I added it to meson and had written some scripts to disable it by default. Should I make a PR now (and should I leave it in separate branch or merge it to main for PR)?

rafaelmardojai commented 3 years ago

You can leave it in a separate branch and make the PR against main.