search

dialectlabs / sdk

Apache License 2.0
22 stars 7 forks source link

debt/[CORE-1750]: Versioned Transaction Migration #107

Closed iamalperen closed 1 year ago

iamalperen commented 1 year ago

We were using Transaction but it's legacy and deprecated. We are not migrating our structure to VersionedTransaction

zhelezkov commented 1 year ago

just curios, is sdk migration is necessary or we can avoid it?

dshuvalov commented 1 year ago

As for me, switching from Transaction to VersionedTransaction is a breaking change and I am not sure that it is a backward compatible @tsmbl @zhelezkov @kevindingens wdyt?

tsmbl commented 1 year ago

As for me, switching from Transaction to VersionedTransaction is a breaking change and I am not sure that it is a backward compatible @tsmbl @zhelezkov @kevindingens wdyt?

why breaking? I think both will supported

iamalperen commented 1 year ago

As for me, switching from Transaction to VersionedTransaction is a breaking change and I am not sure that it is a backward compatible @tsmbl @zhelezkov @kevindingens wdyt?

We are supporting both of them. Why do you think it as breaking?

dshuvalov commented 1 year ago

@iamalperen @tsmbl I checked the code and agree with you. It seems we support both versions. So, let's bump the peer deep as I mentioned at the comment above