dialogflow / asr-server

FastCGI support for Kaldi ASR
Apache License 2.0
184 stars 86 forks source link

FST reader update to support new Kaldi versions #39

Closed mdoulaty closed 5 years ago

mdoulaty commented 5 years ago

https://groups.google.com/d/msg/kaldi-help/0SuCkeHyUmU/SogcAuWbBQAJ New Kaldi versions have an updated FST reader

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
googlebot commented 5 years ago

CLAs look good, thanks!

mdoulaty commented 5 years ago

this should solve https://github.com/dialogflow/asr-server/issues/34

realill commented 5 years ago

Does it still work with older FST format? Like this one https://github.com/dialogflow/api-ai-english-asr-model ?

mdoulaty commented 5 years ago

yes, it does

mdoulaty commented 5 years ago

the pre-trained models that you mentioned (https://github.com/dialogflow/api-ai-english-asr-model), works as expected after this change

realill commented 5 years ago

Merged. Thanks.