dialogflow / dialogflow-android-client

Android SDK for Dialogflow
https://dialogflow.com
Apache License 2.0
575 stars 270 forks source link

Workaround for crash, missing getTimeZone() #28

Closed mstratman closed 7 years ago

mstratman commented 7 years ago

This is a naive workaround because AIServiceContext requires getTimeZone(), but AIAndroidServiceContext does not provide it, causing a crash.

mstratman commented 7 years ago

And of course, please feel free to close this if it's altogether unsuitable. I can open an issue instead.

I'm only just getting my feet wet with this SDK.

folomeev commented 7 years ago

Hello! Thank you for your pull request! May you say a few words about what steps have you done before you met a problem? Did you change ai.api:libai version in build.gradle file?

mstratman commented 7 years ago

Sorry, I don't have any other info on-hand. I could try to create a new project with steps to reproduce, but it would take some time since it's currently entangled in a much larger project.

It seems to stem from this interface expecting this method: https://github.com/api-ai/apiai-java-sdk/blob/master/libai/src/main/java/ai/api/AIServiceContext.java

folomeev commented 7 years ago

Your pull request was accepted in some way. Thank you!