dialogic-godot / dialogic-1

Dialogic 1.x - For Godot 3.x!
MIT License
5 stars 4 forks source link

Custom theme on character messes with theme preview #4

Open Jowan-Spooner opened 2 years ago

Jowan-Spooner commented 2 years ago

The problem

This behaviour is somewhat expected but far from what one would expect.

If you select a character for the theme preview that has a custom theme set, it won't actually display the theme you are editing but the custom theme of the character.

Because the character is selected at random by default, this can be VERY VERY confusing as described here #850.

Solutions

coppolaemilio commented 2 years ago

Made it easier to understand what the character picker is by adding proper styling and changing its position. https://github.com/coppolaemilio/dialogic/commit/b35e439054a83e9c202661cf89aea872b71587c7

The fix for the other two tasks are coming whenever I can continue.

coppolaemilio commented 2 years ago

Fixed the first one Characters with custom themes should only be suggested/possible if it's their theme that is edited. Only the last one needs to be fixed, but I might not include it into Dialogic 1.4.2 since we are already going too over the scope of the update