dialogic-godot / dialogic

💬 Create Dialogs, Visual Novels, RPGs, and manage Characters with Godot to create your Game!
https://dialogic.pro
MIT License
3.42k stars 206 forks source link

Refactor Manual-Advance to `Dialogic.Inputs.manual_advance` #2124

Closed CakeVR closed 2 months ago

CakeVR commented 2 months ago

Evens out the difference between Auto-Advance, Auto-Skip, and Manual-Advance by turning it into a property on the Inputs-subsystem.

This has a breaking impact on the API and results in the following changes:

Setting the enable state of Manual-Advance:

# Old:
Dialogic.Inputs.set_manualadvance(true, false)

# New:
Dialogic.Inputs.manual_advance.enabled_forced = true
Dialogic.Inputs.manual_advance.enabled_until_next_event = false

Getting the enable state of Manual-Advance:


# Old:
var result := Dialogic.Inputs.is_manualadvance_enabled()

# New:
var result := Dialogic.Inputs.manual_advance.is_enabled()
Jowan-Spooner commented 2 months ago

Thank you, it's great having them all match!