search

dialogic-godot / dialogic

💬 Create Dialogs, Visual Novels, RPGs, and manage Characters with Godot to create your Game!
https://dialogic.pro
MIT License
3.35k stars 206 forks source link

Remember the Timeline Sidebar Size #2153

Closed CakeVR closed 1 month ago

CakeVR commented 1 month ago

When reloading the project, the right sidebar of the timeline editor does not remember its last manually set size.

This pull request saves the size as project setting, assigns the correct size to all relevant containers, and sets the proper event button style.

Closes #2152

Jowan-Spooner commented 1 month ago

@CakeVR We have our own "editor settings" for this, stuff like this should not be stored in the project settings, because it's super annoying for vcs, especially in a team. You should use: DialogicUtil.set_editor_setting() DialogicUtil.get_editor_setting()

Also I'll have to take another look, but I had tried to implement this originally, but somehow it didn't work, not sure if there are any leftovers from that attempt.

CakeVR commented 1 month ago

Thanks a lot, I use DialogicUtil now and it still works.

Jowan-Spooner commented 1 month ago

There is now an error, because initialized is using two different spellings!

Jowan-Spooner commented 1 month ago

Looks good to me. Thanks!