dialogic-godot / dialogic

💬 Create Dialogs, Visual Novels, RPGs, and manage Characters with Godot to create your Game!
https://dialogic.pro
MIT License
4.02k stars 239 forks source link

Cannot save Character (.dch) changes directly from Dialogic edit panel, can force save in scene 2D/3D view or by playing but then asterisk remains #2227

Open hsandt opened 6 months ago

hsandt commented 6 months ago

The problem

Describe the bug After editing a character property e.g. Display Name and pressing Ctrl+S, the character is not saved (can be verified in git diff) (behavior bug) and the dirty asterisk remains visible (that is not an extra bug and shows reality).

I found 3 ways to force save:

To Reproduce Steps to reproduce the behavior:

  1. Open Dialogic panel and Create new character
  2. Change some property e.g. Display Name
  3. Ctrl+S to save => no save at all
  4. Variant 1: switch to another view (outside Dialogic) and save => saved, but asterisk remains when coming back
  5. Variant 2: play => saved, but asterisk remains

Expected behavior Character changes should be saved

Screenshots

image

System (please complete the following information):

hsandt commented 6 months ago

I got a similar issue with Dialogic Settings but there is no dirty asterisk at all. I may open another issue for this one if I find the exact conditions.

CakeVR commented 6 months ago

Make sure that the version you use is the one from the main branch. Alpha 13 is very outdated by now.

hsandt commented 6 months ago

Apparently I was in fact using main commit a9c56aa6 from 2024-05-05. Only 5 commits have been done since, including some to fix bugs I opened recently. I updated Dialogic version in my OP.

AnidemDex commented 6 months ago

I found something related while doing some tests with b14d635 in 4.3: Dialogic marks the scene state as modified/unsaved when loading (not even editing) any of its resources

Jowan-Spooner commented 6 months ago

This is strange, saving characters with CTRL+S works for me.

Jowan-Spooner commented 4 months ago

Cannot recreate. Please provide more information on your setup.