search

dialogic-godot / dialogic

💬 Create Dialogs, Visual Novels, RPGs, and manage Characters with Godot to create your Game!
https://dialogic.pro
MIT License
3.42k stars 206 forks source link

History enabled by default, but shown as disabled in the settings #2228

Closed coppolaemilio closed 2 weeks ago

coppolaemilio commented 2 weeks ago

Dialogic: latest from main Godot version: 4.3.dev6

I created a test timeline, and noticed that now, on a brand new project, you see the history button at the top.

image

But the project settings have this unchecked:

image

I think the history button should only show if you actively want it by enabling in the settings. So I'd say the settings are correct here and the default template is not.

coppolaemilio commented 2 weeks ago

Additionally, if you toggle the first checkbox, it will be correct and hide the history button

Jowan-Spooner commented 2 weeks ago

Then this is probably a problem with default values. Usually we assume default values for dialogic settings in multiple places and those assumptions can get out of sync. So I'd assume the game assumes it's on by default, while the settings page considers it off by default. This happens when no actual value has been stored for the setting.

coppolaemilio commented 2 weeks ago

Makes sense, so I guess the fix would be to disable the history by default on the default theme 👍