dialogic-godot / dialogic

💬 Create Dialogs, Visual Novels, RPGs, and manage Characters with Godot to create your Game!
https://dialogic.pro
MIT License
3.54k stars 216 forks source link

Background Transition Blurry (Linear Filtering) #2322

Open NatePlays95 opened 1 week ago

NatePlays95 commented 1 week ago

The problem

Describe the bug Background image transitions become blurry during any of the default background transitions, despite the chosen default texture filtering in Project Settings

To Reproduce

Expected behavior The filtering mode for the background transition shaders should respect the filtering mode I set as default in the editor in rendering/textures/canvas_textures/default_texture_filter, and I possibly be able to edit the filtering mode as a setting of the BackgroundLayer in the style editor.

Screenshots

How it is supposed to look (paused during a transition): image

How it looks by default: image

System (please complete the following information):

Solutions

Workaround

My game is made entirely with pixel art so I can afford modifying the default shaders directly. image

Possible fixes If possible, these sampler filter types should be set to the system default when the shader is instantiated.

Jowan-Spooner commented 4 days ago

I agree that this would be better behaviour, though I'm not sure if this is possible without switching out the whole shader. This seems to be the relevant godot issue: https://github.com/godotengine/godot/issues/57679