search

dialogic-godot / dialogic

💬 Create Dialogs, Visual Novels, RPGs, and manage Characters with Godot to create your Game!
https://dialogic.pro
MIT License
3.79k stars 219 forks source link

Godot 4.3 Resource icons! #2355

Open firedfromlife opened 1 month ago

firedfromlife commented 1 month ago

Is your feature request related to a problem? Please describe. Finally, as of Godot 4.3 custom resources can have their own icons! Timelines and Characters should absolutely support this

Describe the solution you'd like Add the new @ icon annotation to those classes.

Additional context I intend to submit a PR for this, though it seems @ icon annotation doesn't work correctly for custom extensions?

firedfromlife commented 1 month ago

I also realized, there currently isn't a custom icon for the timelines. It just uses the three line hamburger menu icon. I came up with one real quick, any thoughts?

I fear it may not read at lower resolutions so I may change it.

image

Jowan-Spooner commented 1 month ago

Yeah, I think this won't work as an icon. Feel free to try out some more though! We certainly need an svg. You can find the svgs of all the godot icons here, in case it helps 😋: https://github.com/godotengine/godot/tree/master/editor/icons

I think timeline is a hard concept to put into a small icon, so I assume we can't get much better then what we have right now, but maybe there is a way to make it NOT look like a hamburger menu :)? Good luck, I'll test the sidebar PR tomorrow, for now I'm of to bed...

firedfromlife commented 1 month ago

A couple other options:

Am done for today, but let me know.

firedfromlife commented 1 month ago

I filed an issue with with Godot engine, and the issue has now been confirmed in 4.3 rc1. Custom icons for resources do not work with custom file extensions at the moment... At least in the file system. Hopefully will get fixed prior to 4.3 release.