search

dialogic-godot / dialogic

💬 Create Dialogs, Visual Novels, RPGs, and manage Characters with Godot to create your Game!
https://dialogic.pro
MIT License
3.42k stars 206 forks source link

Hide the Text Event Character picker if there are no character resources in the project #443

Closed coppolaemilio closed 2 years ago

coppolaemilio commented 2 years ago

Kinda weird to see it there if there are no options to select.

zaknafean commented 2 years ago

Pretty easy fix using the DialogicUtil class to check if a character exists. The event part is hidden fine and reappears when you add a character properly. Only real question would be should we have a message about adding a character up there rather than just having it be blank?

coppolaemilio commented 2 years ago

it could be interesting to add, but not sure if it would add much to the plugin tbh. If you want to add a character I feel like the character folder is right there for you to add. My main issue is: imagine someone is using dialogic but doesn't want to deal with characters: why should they see the prompt of "create a character! click here!" on every text event 🤔

coppolaemilio commented 2 years ago

Maybe on the only place that this should happen is in the "character join" event. Where if no characters exists it will prompt you to create one!

zaknafean commented 2 years ago

Not going to try to figure out what this does... image

But I wonder if we may not need it now. Added your idea to Character Join and Character Leave image

EDIT: I didn't like the wording. Changed it to "You haven't created a character yet."

coppolaemilio commented 2 years ago

that's great, can you add maybe a button that would create a character as well?

zaknafean commented 2 years ago

Seems reasonable. I'll see how well it flows.

coppolaemilio commented 2 years ago

Thanks! you can also probably replace the get_node('../../.././././././....././././.') or whatever with a find_parent 🤣

zaknafean commented 2 years ago

I think the whole .../........../.. is most easily solved by not having Character Leave and Text Event share an Event Part. They seem to have different wants, but that's out of scope for this at the moment.

The button thing works better than I'd have thought! Only real question is if 'flat button' is better than regular button. Below 'Join' is flat, 'Leave' is an adjusted.

image

coppolaemilio commented 2 years ago

I would do: You haven't created a character yet. Click [here] to create one.

zaknafean commented 2 years ago

mmm ya that looks better. Will send the pull request up for a once over.

image