search

dialogos-project / dialogos

The DialogOS dialog system.
https://www.dialogos.app
GNU General Public License v3.0
21 stars 8 forks source link

Find... feature doesn't see plugins #174

Open TheresaSchmidt opened 5 years ago

TheresaSchmidt commented 5 years ago

Describe the bug I observed that when I search for a variable, plugin nodes using this variable are not found. Also, they are not listed in the drop-down for the search for node types. They are found, however, when searching for the nodes' names.

To Reproduce Please attach a minimal example dialog exposing the bug if applicable. Steps to reproduce the behavior:

  1. Example: find.zip
  2. Go to menu Nodes > Find... or use Strg + F to open the search mask.
  3. Select Uses variableand type in test.
  4. test is found only in the variable setting node, although it is also used in the speech recognition node as well as in the speech synthesis node.

Expected behavior The search should find every appearance of the variable in the whole dialogue. Otherwise it's not helpful.

Installation information

timobaumann commented 5 years ago

there's a find functionality in DialogOS?

akoehn commented 5 years ago

I also did not know that. I think that this functionality has to be somehow implemented by the nodes and it is unclear to me whether it is actually desirable to search for content. Should Script/Groovy nodes search their code? Should recognizer nodes search their recognized words or grammar?

TheresaSchmidt commented 5 years ago

Yes, it very desirable to complete and enhance the find functionality! We would also really appreciate it if you could enter just any kind of text and it searched everywhere (node names, node descriptions, grammars, patterns, notes, ...).