search

dialogos-project / dialogos

The DialogOS dialog system.
https://www.dialogos.app
GNU General Public License v3.0
21 stars 8 forks source link

Inconsistent localisations for output nodes #216

Open alexanderkoller opened 3 years ago

alexanderkoller commented 3 years ago

Describe the bug Many strings are not localized in AbstractOutputNode.

One particularly weird bug is that "GroovyScript" in the radio button labels of the node editor panel localizes to German as "Groovy-Skript" in MaryTTS nodes, but as "Groovy Skript" in Google TTS nodes. This despite the fact that "GroovyScript" is correctly localized as "Groovy-Skript" in the resource bundle of the Google TTS plugin.

timobaumann commented 2 weeks ago

Alexander, you mean that AbstractOutputNode should be in charge of hosting its own Resources (at least the ones that are drawn by it) instead of using an abstract method getResource? (That's a reasonable move; I don't know if otherwise there are differences between the UI elements.) As for your concrete example: Diamant_de.properties sets the key GroovyScript to "Groovy Skript" whereas MaryTTS's Resources_de.properties sets it to Groovy-Skript. It just appears that both plugins want to do different things; I don't see MaryTTS being at fault here.