dialogos-project / dialogos

The DialogOS dialog system.
https://www.dialogos.app
GNU General Public License v3.0
20 stars 7 forks source link

Associate *.dos filename extension with DialogOS in installer #83

Open alexanderkoller opened 6 years ago

alexanderkoller commented 6 years ago

We chose "*.dos" as the default filename extension for DialogOS dialog models (e.g. in file chooser dialogs). If possible, we should offer the user to associate this filename extension with DialogOS in the installer, so dialog models can be opened by double-click.

timobaumann commented 6 years ago

(presumably, untested) done for Windows and Macos in https://github.com/dialogos-project/dialogos-distribution/commit/e55613a1742aa43ef6b189937b3421a911dec09c

timobaumann commented 5 years ago

haven't heard back about this, so closing under the assumption that it does work.

alexanderkoller commented 5 years ago

On MacOS the filename extension doesn't work. We should look into this.

I haven't tested it on Windows, but let's leave the issue open until we have positive evidence that it works.

alexanderkoller commented 5 years ago

The students have reported that the filename extension doesn't work on Windows (with DialogOS 2.0.1, where I changed the filename extension in the install4j config file to "dos" instead of ".dos" - maybe that was a Verschlimmbesserung?).

alexanderkoller commented 5 years ago

It looks like the changes I made to the install4j file for 2.0.3 now associate the "*.dos" extension with DialogOS, both on MacOS and Windows. However, double-clicking does not work correctly:

alexanderkoller commented 5 years ago

I think the easiest way to fix this would be to change the command-line arguments so you can just say

dialogos <modelfile.dos>

instead of

dialogos -model <modelfile.dos>

Does anyone see a problem with this?

akoehn commented 5 years ago

I think that dialogos <modelfile.dos> is what most people would expect when running dialogos from the command line.

timobaumann commented 5 years ago

I'd think dialogos modelfile.dos should load the file, yes. does dialogos -model modelfile.dos immediately start the interaction? or is there a second switch for that?

alexanderkoller commented 5 years ago

This works on Windows now.

On MacOS, when I double-click on a .dos file, DialogOS is opened, but the .dos file is not loaded. This is because the double-clicked file is not passed as an ordinary command-line parameter on recent versions of MacOS. Instead, the DialogOS Java program is called with no command-line arguments. We need to figure out how to do this - maybe there's a way with install4j, but I couldn't find it.

alexanderkoller commented 5 years ago

Seems to work for Urs Peter on MacOS Mojave.