Closed arththebird closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
b452435
) 100.00% compared to head (954cf21
) 100.00%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks! well done.
Description
Split the main
sqla
andasyncio_support
modules into multiple smaller modules with their own purpose. This should help properly separate concerns instead of having everything bundled together. This change shouldn't cause any issue since we expect people to import the classes and objects from the root module likefrom fastapi_sqla import Session
.Additional details
pagination.py
andasync_pagination.py
Base
model is now part ofmodels.py
asyncio_support.py
was renamed toasync_sqla.py
since it's not containing all the async code anymore, and because it makes more sense with the addition ofasync_pagination.py
. It shows in a better way that it's the async version of thesqla
module.setup
function was moved tobase.py
so that the__init__.py
file only contains imports of what we want to expose from the root module. This uses a similar design as the pydantic or fastapi packages.Related JIRA issues
Validation
No code change, only moving things around. Tests still pass with minimal changes.