Closed vtremblay closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
b0c9405
) to head (5b6fa79
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Why not change setup
to use lifespan rather than having library users to do so?
Also, why changing setup
to setup_middlewares
? is that necessary? Whenever we'll want to setup something_else
, will we add a setup_something_else
Can't we just keep setup
?
-> #142
Problem
FastAPI SQLA Cannot be used with the FastAPI Lifespan, only with the deprecated startup/shutdown events.
Solution
Split the setup function into two smaller ones; the first one should be called in the Lifespan function and the second one is used to register the middlewares (which cannot be done in the lifespan)
Note that the previous
setup
function is still there for backward compatibilityValidation
Tested in ER: 1) The app boot correctly using a Lifespan instead of the events 2) The test are all passing