Closed edouardlp closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
b496e04
) to head (0679b79
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Problem
To work around limitations of tox and poetry, we weren't using dev dependencies and extras properly. This creates issues when renovate determines the semantic commit type, leading to incorrect versioning of the library.
Solution
Validation
✅ poetry run tox -e poetry run tox -e sqlalchemy(version) performs the correct installs (beyond
poetry install
)✅ poetry run tox -e sqlalchemyXX-(packages) installs the proper packages at the end
Note that this is clearly inefficient, but it's one of the tradeoffs of this approach, and in practice only adds a few ms to the test execution
✅ poetry run tox -e sqlalchemyXX-pydantic1-YY instals pydantic 1 at the end with
pip install pydantic==1.10.16
✅ Coverage remains 100% which means we test all the conditional tests