diambra / arena

DIAMBRA Arena: a New Reinforcement Learning Platform for Research and Experimentation
https://docs.diambra.ai
Other
307 stars 22 forks source link

Add agents tests to CICD #70

Closed alexpalms closed 1 year ago

alexpalms commented 1 year ago

@discordianfish As an additional comment, note that the test CICD file I have here, is very similar to the one I use in agents for their own CICD tests (https://github.com/diambra/agents/blob/fix-test-cicd/.github/workflows/test.yaml), so there is duplicated code.

We could probably import that file somehow, or call that CICD from within this one making sure that it installs this specific arena version (instead of the default one that is called there).

But maybe this is ok for now and we can avoid overthinking it.

Let me know!

discordianfish commented 1 year ago

@discordianfish As an additional comment, note that the test CICD file I have here, is very similar to the one I use in agents for their own CICD tests (https://github.com/diambra/agents/blob/fix-test-cicd/.github/workflows/test.yaml), so there is duplicated code.

Yes, you can create a re-usable workflow: https://docs.github.com/en/actions/using-workflows/reusing-workflows#creating-a-reusable-workflow And then call that from both the agents repo as well as from here