search

diamirio / BiometricAuth

Backport of Android Pie's BiometricPrompt using Kotlin and RxJava
Other
44 stars 6 forks source link

Add AndroidX BiometricPrompt #13

Closed FlowMo7 closed 4 years ago

FlowMo7 commented 4 years ago

Adds the androidx BiometricPrompt to be used optionally instead of the custom implemented backport.

Main difference in those two is, that the androids BiometricPrompt is not necessarly shown as BottomNavigationSheet.

FlowMo7 commented 4 years ago

Would like to hear your feedback on how to include the possibility to use the AndroidX backport of the BiometricPrompt, which has a different design than the "native" BiometricPrompt as well as the current custom implementation for pre-android-10 devices):

Biometric-Prompt using the AndroidX backport on a Huawei Android 8 device: BiometricPromptAndroidX

Biometric-Prompt using the custom backport on a Huawei Android 8 device: BiometricPromptCustom

First thought (and currently implemented) is to have an additional useAndroidXBiometricPrompt parameter, which defaults to the bevahior it had bevore (not usin the androidX backport).

FlowMo7 commented 4 years ago

without the flag it still uses the "old" way with bottomsheets everywhere right?

Yes, so current behavior (in UI) would not be changed by just updating the library.