search

diamirio / BiometricAuth

Backport of Android Pie's BiometricPrompt using Kotlin and RxJava
Other
44 stars 6 forks source link

Migrate library and app to RxJava3, update dependencies and gradle, c… #18

Closed G00fY2 closed 3 years ago

G00fY2 commented 4 years ago

…leanup code

Since RxJava2 is in maintenance mode now, more and more libraries have and will update to RxJava3.

This PR migrates the library and sample app to RxJava3 and should therefore be handled as a potential new major release.

Because RxJava3 depends on Java 8 language features the project has to target Java 8 as well. The other behavior changes should not affect this library.

Additional changes: I updated to the latest Kotlin 1.4 release and cleaned up the gradle script (e.g. stdlib dependency is added automatically). I switched to SAM conversions and removed unnecessary type arguments. I had to update Gradle (6.5+ is required for Android Studio 4.1) and the Gradle wrapper.

I was only able to test the changes on 2 physical devices (Android 10+11) so far. Everything was working.

FlowMo7 commented 4 years ago

Hey, sorry for the delayed response here. First of all, thanks for the PR!

While it makes sense to update from a maintenance-only RxJava major version, I would actually more see this as an possible additional artifact instead of an update of the existing artifact, due to the non.backwars compatibility. Furthermore, as we have already switched many projects to not use RxJava but Kotlin coroutines and Flow, I would also like this library to provide an Kotlin Flow artifact, once we find the time for it.

With that in mind, I guess providing RxJava3 compatibility as an additional artifact instead of an update to the existing would be benefitial.

Unfortunately we're focused on different things right now, once I find a free slot to do that I am happy to take this PR and provide it as an additional artifact to the existing one.

G00fY2 commented 4 years ago

Hi Flo,

thanks for replying. We are also moving to coroutines in newer projects and I am also not really sure how many libs will actually move to RxJava3 in the Android world (OkHttkp and Room e.g. support it atm). In the end this will affect the decision if we will migrate current projects that use RxJava2. This library would be another reason for a migration.

But other then e.g. the move to AndroidX there is currently not "strong" need for RxJava3 support. I am completely fine if there is no release in the near future and you may close this PR until you possibly migrate the lib your own. :blush:

FlowMo7 commented 3 years ago

Closing this in favor of #20, where the changes have been implemented, but it was easier to do them in there manually, than using this PR, sorry for that (the PR was still very helpful for that!).