diamond-gold / DummyItemsBlocks

🗿 Adds items and blocks for decoration purposes
https://poggit.pmmp.io/p/DummyItemsBlocks
MIT License
24 stars 9 forks source link

Client Crash with version 1.20.40 in worlds with missing tile #12

Closed Nat392 closed 10 months ago

Nat392 commented 10 months ago

Hello, your plugin crashes & timeouts minecraft with update 1.20.40. When we join, our minecraft closes

diamond-gold commented 10 months ago

I am not able to reproduce this bug using a vanilla world that contains every block, would it be possible to share the world that is affected?

Nat392 commented 10 months ago

The thing is, this is our spawn... But if you look in #support on the Pocketmine server several people are also complaining about the bug with your plugin.

I am not able to reproduce this bug using a vanilla world that contains every block, would it be possible to share the world that is affected?

Nat392 commented 10 months ago

https://discord.com/channels/373199722573201408/480650036972224513/1167081944018866210

diamond-gold commented 10 months ago

I need to identify which block is causing this bug, as far as I can see none of the blocks added by this plugin changed https://github.com/pmmp/BedrockData/commit/37e780d28b470230bda3579b04cb50d406e3fbe6

stevsee commented 10 months ago

I need to identify which block is causing this bug, as far as I can see none of the blocks added by this plugin changed pmmp/BedrockData@37e780d

I am not able to reproduce this bug using a vanilla world that contains every block, would it be possible to share the world that is affected?

hub.tar.gz

try my hub spawn

dzolnowski commented 10 months ago

From Bedrock Gopher discord: the crashing issue is coming from blocks not having a tile send with them in the levelchunk packet that the block is sent in (examples are dispenser, dropper and chiseled bookshelf)

VisKaRaZe commented 10 months ago

I have same bug

diamond-gold commented 10 months ago

From Bedrock Gopher discord: the crashing issue is coming from blocks not having a tile send with them in the levelchunk packet that the block is sent in (examples are dispenser, dropper and chiseled bookshelf)

In that case, it is not the fault of this plugin. The plugin places the tile when you place the block. Plus it is also not possible to add a tile when the block is loaded, so there is nothing that can be done on my side.

Your best bet is to load the world in vanilla, which will help you add the tile.

MateusBlackyOFC commented 10 months ago

From Bedrock Gopher discord: the crashing issue is coming from blocks not having a tile send with them in the levelchunk packet that the block is sent in (examples are dispenser, dropper and chiseled bookshelf)

In that case, it is not the fault of this plugin. The plugin places the tile when you place the block. Plus it is also not possible to add a tile when the block is loaded, so there is nothing that can be done on my side.

Your best bet is to load the world in vanilla, which will help you add the tile.

It may not be an error in your plugin, but it only occurs if your plugin is on the server!!!

diamond-gold commented 10 months ago

From Bedrock Gopher discord: the crashing issue is coming from blocks not having a tile send with them in the levelchunk packet that the block is sent in (examples are dispenser, dropper and chiseled bookshelf)

In that case, it is not the fault of this plugin. The plugin places the tile when you place the block. Plus it is also not possible to add a tile when the block is loaded, so there is nothing that can be done on my side. Your best bet is to load the world in vanilla, which will help you add the tile.

It may not be an error in your plugin, but it only occurs if your plugin is on the server!!!

The same crash will occur if you try to place a dispenser in PM4 without a plugin that adds it. Blame Mojang ¯(°_o)/¯ Anyway you can choose to remove those blocks in config.yml