search

diamondburned / chatkit

chatkit provides a variety of useful widgets for making any chat application in GTK4.
GNU General Public License v3.0
3 stars 2 forks source link

embed.Viewer controls overlap with video controls #4

Open diamondburned opened 9 months ago

diamondburned commented 9 months ago

image

I'm not too sure how else to design this.

diamondburned commented 9 months ago

On mobile, the 3 buttons are tucked in an expandable menu. We should probably revert to the previous design with the top-right button, but collapse them into a 3-dot on mobile somehow.

cc @tfuxu do you have any thoughts on this? Does Adwaita have anything that lets us easily do this (besides GtkPopoverMenu or GtkButton with actions)?

tfuxu commented 9 months ago

Sorry for not responding, I haven't got an notification for this issue.

I think that videos should not be showed in viewer at all, but instead they should have an fullscreen mode.

diamondburned commented 9 months ago

I think that videos should not be showed in viewer at all, but instead they should have an fullscreen mode.

Hmm, I modified the behavior so that videos aren't inlined, so now the viewer always shows up for a video. This has the advantage of video loading being a bit less buggy (but still somewhat buggy -- see #5). It also matches the mobile client's behavior.

GIFVs now play on hover like GIFs are, however I'm not confident that they're handled properly. At the very least, they should be stopped when the window goes out of focus.