change direct message icon

[ghost]

yes/no? thoughts? to me it still looks like a placeholder icon, but a slightly nicer

[TheK0tYaRa]

Seems too flat, may confuse Discord's law speakers into DMCA

[diamondburned]

OK, I'm not sure why the DM icon is a green circle on your screen. Perhaps we need to embed an SVG.

It should look like this:

[diamondburned]

Relying on the icon theme doesn't seem like the best idea.

[ghost]

Currently it's a status icon for when a user is available, and it's different across icon themes. Default Adwaita has the speech bubble, but it's huge. What icon theme are you using?

[diamondburned]

What icon theme are you using?

I'm using Papirus.

I'll probably get a new icon from Google Material Icons.

[ghost]

don't use b908c49bf1942f74413979687fb45d8d34f2db09, https://fonts.google.com/icons?icon.style=Rounded&icon.query=message indeed has good icons

[diamondburned]

Hmm, I can't seem to get the CI to run.

[ghost]

this is how it looks currently (39487c82f2849b5cdcbdb4794bef3597cc92fa84): (themes from left to right: Dracula, Adwaita, Adwaita-dark) (with libadwaita compiled)

• changes dark/light depending on gtk theme
• icon for dark theme is #DEDEDE
• icon for light theme is #2E3436

[diamondburned]

I think it looks a bit too big.

[diamondburned]

Can you apply this diff?

diff --git a/internal/gtkcord/sidebar/directbutton/button.go b/internal/gtkcord/sidebar/directbutton/button.go
index 44a6c08..989932e 100644
--- a/internal/gtkcord/sidebar/directbutton/button.go
+++ b/internal/gtkcord/sidebar/directbutton/button.go
@@ -2,6 +2,7 @@ package directbutton

 import (
    "context"
+   "math"

    "github.com/diamondburned/gotk4/pkg/gtk/v4"
    "github.com/diamondburned/gotkit/gtkutil/cssutil"
@@ -23,6 +24,10 @@ var dmButtonCSS = cssutil.Applier("sidebar-dm-button-overlay", `
        padding: 4px 12px;
        border-radius: 0;
    }
+   .sidebar-dm-button image {
+       padding-top: 4px;
+       padding-bottom: 2px;
+   }
 `)

 func NewButton(ctx context.Context, open func()) *Button {
@@ -30,14 +35,13 @@ func NewButton(ctx context.Context, open func()) *Button {

    icon := gtk.NewImageFromPixbuf(icons.Pixbuf("dm"))
    icon.SetIconSize(gtk.IconSizeLarge)
-   icon.SetPixelSize(gtkcord.GuildIconSize)
+   icon.SetPixelSize(int(math.Round(gtkcord.GuildIconSize * 0.85)))

    b.Button = gtk.NewButton()
    b.Button.AddCSSClass("sidebar-dm-button")
    b.Button.SetTooltipText("Direct Messages")
    b.Button.SetChild(icon)
    b.Button.SetHasFrame(false)
-   b.Button.SetHAlign(gtk.AlignCenter)
    b.Button.ConnectClicked(func() {
        b.Pill.State = sidebutton.PillActive
        b.Pill.Invalidate()
diff --git a/internal/gtkcord/sidebar/guilds/guilds.go b/internal/gtkcord/sidebar/guilds/guilds.go
index 16bdd67..b0db65a 100644
--- a/internal/gtkcord/sidebar/guilds/guilds.go
+++ b/internal/gtkcord/sidebar/guilds/guilds.go
@@ -54,6 +54,9 @@ type currentGuild struct {
 }

 var viewCSS = cssutil.Applier("guild-view", `
+   .guild-view {
+       margin: 4px 0;
+   }
    .guild-view button:active:not(:hover) {
        background: initial;
    }