diamondburned / dissent

Tiny native Discord app
https://flathub.org/apps/details/so.libdb.dissent
GNU General Public License v3.0
1.3k stars 41 forks source link

Missing compiled binaries in latest release #140

Closed txtsd closed 1 year ago

txtsd commented 1 year ago

v0.0.11 does not have compiled binary artifacts like the other releases do.

diamondburned commented 1 year ago

It seems to be caused by the cmd/cgo patches that I have in the Go compiler used for this build, which made the build very unstable and indeterministic:

# github.com/diamondburned/gotk4/pkg/gio/v2
vendor/github.com/diamondburned/gotk4/pkg/gio/v2/gsettings_export.go:56:79: syntax error: mixed named and unnamed parameters
vendor/github.com/diamondburned/gotk4/pkg/gio/v2/gsettings_export.go:110:31: syntax error: unexpected _Ciconst_TRUE, expected )
vendor/github.com/diamondburned/gotk4/pkg/gio/v2/gsettings_export.go:110:15: syntax error: unexpected ) at end of statement

There are two possible fixes here: either rollback to Go 1.19 which doesn't have this behavior, or the pipeline takes at least twice as long to build.

diamondburned commented 1 year ago

I created https://github.com/diamondburned/gtkcord4/releases/tag/v0.0.11-1 to fix this.

diamondburned commented 1 year ago

Closing since the binaries are there now.