Closed tfuxu closed 10 months ago
There are slight issues with this:
There are slight issues with this:
1. How would this look on mobile? Especially when replying, there will be 4 buttons down there! 2. How about custom emojis? Shouldn't that also be accounted for?
It shouldn't look bad on mobile, Fractal also has four buttons in composer and without showing scrollbar is able to store the same amount of characters as gtkcord (20 letters).
Also, custom emojis should be accounted, but for now I think that bare gtk.EmojiChooser
should be sufficient, as this is the only way mobile users can put emojis in message (without using external programs or mouse).
this is the only way mobile users can put emojis in message (without using external programs or mouse).
That's interesting. I would've expected holding the input bar to work.
Is this PR ready to be merged?
Is this PR ready to be merged?
Yes
This PR adds an emoji menu button to composer, which shows
gtk.EmojiChooser
when clicked.Screenshot:![Screenshot from 2023-09-30 15-05-15](https://github.com/diamondburned/gtkcord4/assets/73042332/79a6ad04-ccd1-45c1-ac04-d18b5166942b)