search

diamondburned / dissent

Tiny native Discord app
https://flathub.org/apps/details/so.libdb.dissent
GNU General Public License v3.0
1.23k stars 39 forks source link

Add emoji button to composer #163

Closed tfuxu closed 10 months ago

tfuxu commented 10 months ago

This PR adds an emoji menu button to composer, which shows gtk.EmojiChooser when clicked.

Screenshot: Screenshot from 2023-09-30 15-05-15

diamondburned commented 10 months ago

There are slight issues with this:

  1. How would this look on mobile? Especially when replying, there will be 4 buttons down there!
  2. How about custom emojis? Shouldn't that also be accounted for?
tfuxu commented 10 months ago

There are slight issues with this:

1. How would this look on mobile? Especially when replying, there will be 4 buttons down there!

2. How about custom emojis? Shouldn't that also be accounted for?

It shouldn't look bad on mobile, Fractal also has four buttons in composer and without showing scrollbar is able to store the same amount of characters as gtkcord (20 letters).

Screenshot from 2023-10-01 14-07-23

Also, custom emojis should be accounted, but for now I think that bare gtk.EmojiChooser should be sufficient, as this is the only way mobile users can put emojis in message (without using external programs or mouse).

diamondburned commented 10 months ago

this is the only way mobile users can put emojis in message (without using external programs or mouse).

That's interesting. I would've expected holding the input bar to work.

diamondburned commented 10 months ago

Is this PR ready to be merged?

tfuxu commented 10 months ago

Is this PR ready to be merged?

Yes