diamondburned / dissent

Tiny native Discord app
https://flathub.org/apps/details/so.libdb.dissent
GNU General Public License v3.0
1.23k stars 39 forks source link

On high-DPS screens, images are unpleasantly small #180

Closed aaannestad closed 10 months ago

aaannestad commented 10 months ago

I'm running gtkcord4 on a 4k screen, and the images displayed in the feed for a given channel are very unpleasantly small. Not completely uselessly small, but enough so that I pretty much have to click on every single one to get much out of them.

This would be not too much of an issue if there was an in-app full-size image popup, but as it is opening each image kicks me back to the browser every time, which is a very inconvenient interaction flow. Dynamic image preview resizing based on the message width setting would also solve the issue. As it is, though, reading through image-focused channels on a 4k monitor without some convenient means to make them larger is miserable enough to be a barrier to me using gtkcord4 as my regular Discord client.

You can see how small they are relative to the text here - image

Compare that to the official Discord client - image

diamondburned commented 10 months ago

What's the scaling factor of your 4K display?

aaannestad commented 10 months ago

125%.

diamondburned commented 10 months ago

Is this an issue with 175% scale factor? That's what I seem to use.

diamondburned commented 10 months ago

You can also confirm that this is in fact a scaling issue and not just gtkcord4's image size being too small by running with WAYLAND_DISPLAY= gtkcord4.

aaannestad commented 10 months ago

I guess it's a scaling issue (WAYLAND_DISPLAY= gtkcord4 still has tiny images), but for every other purpose 125% is fine and I strongly prefer it to 175%. I would rather have a way to scale just image previews in gtkcord4 rather than scale everything else on screen just to make that one issue better!

diamondburned commented 10 months ago

WAYLAND_DISPLAY= gtkcord4 still has tiny images

Then it's not a scaling issue. It just seems like a gtkcord4's image size being too small issue.

diamondburned commented 10 months ago

Commit https://github.com/diamondburned/gtkcord4/commit/9c86416db26b8875a3ffcaaa4f73e5e375f5330e adds new preferences to increase the dimension limits. Try increasing it on your end.

aaannestad commented 10 months ago

That is vastly better. Still a shame there's no in-app full-image viewer, but this makes gtkcord4 at least livable. Thank you!

diamondburned commented 10 months ago

This is fixed now, so I'm closing this issue.

I have an image viewer dialog implemented in chatkit, but the panning and zooming aren't working well at the moment.

Perhaps someone else could give it a look?