search

diamondburned / dissent

Tiny native Discord app
https://flathub.org/apps/details/so.libdb.dissent
GNU General Public License v3.0
1.23k stars 39 forks source link

Confirmation dialog on Delete #188

Closed diamondburned closed 9 months ago

diamondburned commented 9 months ago

I keep hitting this button by accident -_-, it really needs a dialog.

We can have the dialog be a toggleable option in Preferences.

Quik2007 commented 9 months ago

It would also be great if the dialog was automatically skipped when pressing Shift (which is the way the first-party client does it)

diamondburned commented 9 months ago

It would also be great if the dialog was automatically skipped when pressing Shift (which is the way the first-party client does it)

This turns out to be way harder than it needs to be on GTK. I'm not sure how to do this properly (i.e. with a PopoverMenu, which is what we're using right now). Pressing Shift also drops it into the mnemonic mode, which lets you do Shift + D to trigger a Delete.

diamondburned commented 9 months ago

This should work for now:

The Delete button is probably red on the proper Adwaita theme. I'm using a custom theme at the moment. A new setting ("Ask Before Deleting") will also be added.

diamondburned commented 9 months ago

I'm closing this issue for now. Please open a new issue if you feel like the holding-Shift feature is worth adding.