diamondburned / dissent

Tiny native Discord app
https://flathub.org/apps/details/so.libdb.dissent
GNU General Public License v3.0
1.18k stars 38 forks source link

Channel list aesthetics #196

Closed ThatOneCalculator closed 6 months ago

ThatOneCalculator commented 7 months ago

Discord electron client with the DNOME theme:

image

gtkcord4:

image

Currently (imo), the gtkcord4 version feels far less inviting, mainly due to a lack of padding, small text, and drop-down style.

diamondburned commented 7 months ago

Fixing this would likely begin at moving the channel list to use ColumnView instead of TreeView, which I've tried before, but it's just a pain in the ass since gotk4 can't do subclassing yet... (blame GTK for its awful lack of documentation!)

An alternative would be to just use regular Popover + List widgets like gtkcord3 had, but manually handling state changes with that was really painful compared to using a TreeStore.

ThatOneCalculator commented 7 months ago

Ah.

blame GTK for its awful lack of documentation!

I'm not a GTK developer, but have you tried Biblioteca?

diamondburned commented 7 months ago

It's more about the lack of documentation (in particular, subclassing documentation), but that's a neat app.

diamondburned commented 6 months ago

Implemented in https://github.com/diamondburned/gtkcord4/commit/2f8a342074f420ef5a21dfb74e8c389d5d77d8ba.

ThatOneCalculator commented 6 months ago

Nice! How do I install the nightly with this? I'm currently using go install -v github.com/diamondburned/gtkcord4@latest

ThatOneCalculator commented 6 months ago

Hm... I did go install -v github.com/diamondburned/gtkcord4@nightly which seems to have worked since the about page shows the version as git (ca66b8d), but the channel list still looks the same-ish

image

diamondburned commented 6 months ago

ca66b8d is not recent enough. Try doing @43d581a. go get also caches tag references a lot, so it's better to directly reference the commit hash.

ThatOneCalculator commented 6 months ago

Awesome, works great!