diamondburned / dissent

Tiny native Discord app
https://flathub.org/apps/details/so.libdb.dissent
GNU General Public License v3.0
1.27k stars 40 forks source link

Fix inconsistent capitalization in app ID #247

Closed tfuxu closed 6 months ago

tfuxu commented 7 months ago

Flathub's backend cares about capitalization in application ID, so it needs to be the same throughout the codebase. Otherwise, appstreamcli will error out with filters-but-no-output error.

This PR should fix issues with app ID and hopefully make appstreamcli happy.

diamondburned commented 7 months ago

Wouldn't so.libdb.dissent be the right capitalization? Or does Flatpak want a capitalized D?

tfuxu commented 7 months ago

There aren't any mentions about capitalization of the app name part in Flathub docs, so I guess it doesn't matter.

diamondburned commented 7 months ago

I personally prefer the so.libdb.dissent, could you update the PR to contain that?

tfuxu commented 7 months ago

@diamondburned Updated