search

diamondburned / dissent

Tiny native Discord app
https://flathub.org/apps/details/so.libdb.dissent
GNU General Public License v3.0
1.27k stars 40 forks source link

feat: Redesigned channel indicators #288

Open DodoLeDev opened 3 months ago

DodoLeDev commented 3 months ago

As suggested in https://github.com/diamondburned/dissent/issues/266#issuecomment-2176902222, here is my PR about Redesigned unread indicators 🔴

Dissent custom unread indicators

diamondburned commented 3 months ago

I'm not sure if this PR isn't rebased as well, but could you make sure that it's up to date with main?

DodoLeDev commented 3 months ago

I'm not sure if this PR isn't rebased as well, but could you make sure that it's up to date with main?

It seems to be up to date... No commit behind found!

image

diamondburned commented 3 months ago

I got this change to work. A small nitpick: how do we expect this change to be usable by colorblind people? Previously, mentions are differentiated from unreads based on an exclamation mark (!). Could this somehow be added back to the design while still making it look good?

diamondburned commented 3 months ago

Also, please fix the indentation of the CSS strings. They should be tab-indented.