search

diamondburned / gtkcord3

A Gtk3 Discord client in Golang
GNU General Public License v3.0
628 stars 28 forks source link

fix build error (handlerrepo -> handler) #94

Closed Titaniumtown closed 4 years ago

Titaniumtown commented 4 years ago

So I was trying to build gtk for #93 and I kept getting an error:

gtkcord/components/popup/stateful.go:10:2: module github.com/diamondburned/ningen@latest found (v0.1.0), but does not contain package github.com/diamondburned/ningen/handlerrepo

But I knew the aur package worked, so I checked out what they did, and they have a patch: https://aur.archlinux.org/cgit/aur.git/tree/fix-build.patch?h=gtkcord3-git which fixes this build. This PR is just applying the patch.

micwoj92 commented 4 years ago

No this is wrong. The right way would be to make new release of ningen and make gtkcord3 use it. This basically reverts last commit lol

Titaniumtown commented 4 years ago

Oh, crap. Should I open an issue on ningen about it then?

Titaniumtown commented 4 years ago

diamondburned/ningen/issues/4

micwoj92 commented 4 years ago

Not sure how you would do it, but IMO the right solution is just to bump ningen like here https://github.com/diamondburned/gtkcord3/commit/08b895cab71b164204d3b9dbcb8f6fb156eadc8e This shouldnt break compatibility while installing manually and should have same intended effect as this pr.

Titaniumtown commented 4 years ago

So my issue I created on the ningen github doesn't make sense and can be fixed on gtkcord3's side?

micwoj92 commented 4 years ago

Ye, I think that's how this works. But it wouldn't hurt to release a new version. Whatever man, git software can and will break

Titaniumtown commented 4 years ago

I don't know much about go, I was just trying to tinker around with litecord (https://gitlab.com/litecord/litecord) and needed a client for it. I've gone down a rabbit hole, lol.

I just saw an issue, and wanted to make a PR with the fix rq.

micwoj92 commented 4 years ago

Could you show the pkgbuild you used in 93?

Titaniumtown commented 4 years ago

I wasn't using a PKGBUILD, I was compiling it w/ go build with some flags.

diamondburned commented 4 years ago

You would need to fix the import path in gtkcord if you want to bump ningen to latest. Else, just a replace directive would work. Something like

replace github.com/diamondburned/ningen => github.com/diamondburned/ningen <latest working hash>