Closed Titaniumtown closed 4 years ago
No this is wrong. The right way would be to make new release of ningen and make gtkcord3 use it. This basically reverts last commit lol
Oh, crap. Should I open an issue on ningen about it then?
diamondburned/ningen/issues/4
Not sure how you would do it, but IMO the right solution is just to bump ningen like here https://github.com/diamondburned/gtkcord3/commit/08b895cab71b164204d3b9dbcb8f6fb156eadc8e This shouldnt break compatibility while installing manually and should have same intended effect as this pr.
So my issue I created on the ningen github doesn't make sense and can be fixed on gtkcord3's side?
Ye, I think that's how this works. But it wouldn't hurt to release a new version. Whatever man, git software can and will break
I don't know much about go, I was just trying to tinker around with litecord (https://gitlab.com/litecord/litecord) and needed a client for it. I've gone down a rabbit hole, lol.
I just saw an issue, and wanted to make a PR with the fix rq.
Could you show the pkgbuild you used in 93?
I wasn't using a PKGBUILD, I was compiling it w/ go build with some flags.
You would need to fix the import path in gtkcord if you want to bump ningen to latest. Else, just a replace directive would work. Something like
replace github.com/diamondburned/ningen => github.com/diamondburned/ningen <latest working hash>
So I was trying to build gtk for #93 and I kept getting an error:
But I knew the aur package worked, so I checked out what they did, and they have a patch: https://aur.archlinux.org/cgit/aur.git/tree/fix-build.patch?h=gtkcord3-git which fixes this build. This PR is just applying the patch.