search

diamondburned / gtkcord3

A Gtk3 Discord client in Golang
GNU General Public License v3.0
628 stars 28 forks source link

Updated Arikawa to v1.3.2, and ningen v0.2.0. #97

Closed PaulDGillis closed 3 years ago

PaulDGillis commented 3 years ago

Lots of refactoring with the updates. I left OnSync and OnMember callbacks commented out since the structure of the new code will take a lot more time to change than I have right now. I made this WIP until I have time to fix it, and have a place to see a real comparison.

x4e commented 3 years ago

Is there anything blocking this from being merged @diamondburned ? This builds and run fine for me as opposed to current master.

diamondburned commented 3 years ago

The author still has this as a draft PR, and there's not a confirmation from them.

That's the only reason, really.

PaulDGillis commented 3 years ago

The only reason this is still a draft is because of OnSync and OnMember callbacks being removed, so merging would be a slight regression. I've been meaning to get back to this but haven't had the time. I can also just mark them as TODO for now and merge to get the more up to date build, since it seems to be needed for BSD?

diamondburned commented 3 years ago

Tip doesn't build at all right now, so the OS is irrelevant. That said, you could split that into another issue and mark this one as ready, if you prefer. I think a minor regression is better than being broken.

PaulDGillis commented 3 years ago

In that case I'll just open a second issue to get master to build again for people.

PaulDGillis commented 3 years ago

@diamondburned I went ahead and re-requested a review, whenever you get a chance. I'm not really in a rush to get this merged, just checking that you saw it. I realize you already reviewed it once, didn't know if you saw anything else wrong with it. Anyway I can't merge this without another review it seems.

diamondburned commented 3 years ago

I've already done a review shortly after your changes, so I'll go ahead and merge this.