diana-hep / oamap

Perform high-speed calculations on columnar data without creating intermediate objects.
BSD 3-Clause "New" or "Revised" License
81 stars 11 forks source link

Organize into databases #5

Closed Jayd-1234 closed 6 years ago

Jayd-1234 commented 6 years ago

Implementation of pairs function in numpy with triu_indices.

Returns a List by default. Can be changed to return a List of Tuples though through switch?

Caveats

Notes

jpivarski commented 6 years ago

You closed it? I really was going to look at it! Are you doing this because you want to redesign? That would be okay. (Sorry that I haven't had time to look at it just yet...)

Jayd-1234 commented 6 years ago

I closed it because I wanted the current operations.py which is under heavy development to be a bit stable. It function still works though, I can create a PR if you want.

jpivarski commented 6 years ago

operations.py is unstable. I'm actively working on it. That's why I suggested that you create a gist of the concise idea, rather than a fully working fork.

I think you updated operations.py by copying the file, which would be counted by git as a conflict.

Don't worry about making it production-quality. Remember that your project is about algorithm development, not packaging. Showing me the idea concisely, without all the caveats that make it production-quality, would also make it easier for me to review.

Jayd-1234 commented 6 years ago

Thanks. I will keep that in mind from now on. :smiley: