Samba NAS: passwords with spaces

[codyrocco]

Addon

SambaNAS

Description

if password for an entry in other_users section contains spaces, addon will not start

Reproduction steps

Edit config in UI, under other_users, like this

- username: luzer
  password: no more passwords

or in YAML

other_users:
  - username: luzer
    password: no more passwords

and restart the addon - will work no more.

Addon Logs

Expose Home Assistant disc with SMB/CIFS
-----------------------------------------------------------
 Add-on version: 12.2.0-nas2
 You are running the latest version of this add-on.
 System: Home Assistant OS 13.1  (amd64 / generic-x86-64)
 Home Assistant Core: 2024.9.0
 Home Assistant Supervisor: 2024.08.0
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub, forums or the Discord chat.
-----------------------------------------------------------
s6-rc: info: service base-addon-banner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service base-addon-log-level: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service base-addon-log-level successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service init-automount: starting
[21:50:15] INFO: Protection Mode is false
[21:50:15] INFO: MoreDisk or Automount option found!
---------------------------------------------------
Supported fs:   ext3    ext2    ext4    squashfs    vfat    msdos   iso9660 erofs   xfs ntfs3   exfat   btrfs
---------------------------------------------------
[21:50:15] INFO: MediaLibrary option found!
---------------------------------------------------
[21:50:15] INFO: Available Disk Labels:
[21:50:15] INFO:    internal-storage[ext4]
---------------------------------------------------
[21:50:15] INFO: No MoreDisks to mount
[21:50:15] INFO: Automount is Enabled!
---------------------------------------------------
[21:50:15] INFO: Checking Mounting disks for reserved names:

    internal-storage
---------------------------------------------------
---------------------------------------------------
[21:50:15] INFO: Mounting disks:

    internal-storage
---------------------------------------------------
[21:50:15] INFO: Mount internal-storage[ext4] Success!
s6-rc: info: service init-automount successfully started
s6-rc: info: service init-smartd: starting
s6-rc: info: service init-samba: starting
s6-rc: info: service hd-idle: starting
s6-rc: info: service hd-idle successfully started
[21:50:15] INFO: Enabling HDD IDLE after 30sec
[21:50:15] INFO: Hostname: ha
symlinkPolicy=0, defaultIdle=30, defaultCommand=scsi, defaultPowerCondition=0, debug=false, logFile=, devices=
[21:50:16] INFO: Enabling S.M.A.R.T for /dev/sda
smartctl 7.4 2023-08-01 r5530 [x86_64-linux-6.6.46-haos] (local build)
Copyright (C) 2002-23, Bruce Allen, Christian Franke, www.smartmontools.org

[21:50:16] INFO: Interfaces: enp0s20f0u4 enp1s0f0 wlp2s0 
[21:50:16] INFO: Docker Interface: hassio 172.30.32.0/23
=== START OF ENABLE/DISABLE COMMANDS SECTION ===
SMART Enabled.
SMART Attribute Autosave Enabled.
SMART Automatic Offline Testing Enabled every four hours.

[21:50:16] INFO: Enabling S.M.A.R.T for /dev/sdb
smartctl 7.4 2023-08-01 r5530 [x86_64-linux-6.6.46-haos] (local build)
Copyright (C) 2002-23, Bruce Allen, Christian Franke, www.smartmontools.org

tdbsam_open: Converting version 0.0 database to version 4.0.
tdbsam_convert_backup: updated /var/lib/samba/private/passdb.tdb file.
=== START OF ENABLE/DISABLE COMMANDS SECTION ===
SMART Enabled.
SMART Attribute Autosave Enabled.
Added user homeassistant.
SMART Automatic Timers not supported

SMART Automatic Offline Testing Enabled every four hours.

s6-rc: info: service init-smartd successfully started
Added user _ha_mount_user_.
jq: parse error: Unfinished string at EOF at line 2, column 0
s6-rc: warning: unable to start service init-samba: command exited 5
/run/s6/basedir/scripts/rc.init: warning: s6-rc failed to properly bring all the services up! Check your logs (in /run/uncaught-logs/current if you have in-container logging) for more information.
/run/s6/basedir/scripts/rc.init: fatal: stopping the container.
s6-rc: info: service init-smartd: stopping
s6-rc: info: service hd-idle: stopping
s6-rc: info: service init-smartd successfully stopped
[21:50:16] INFO: hd-idle stopped
s6-rc: info: service hd-idle successfully stopped
s6-rc: info: service init-automount: stopping
[21:50:16] INFO: Unmount drivers:
/mnt/internal-storage
[21:50:16] INFO: Bye.
s6-rc: info: service init-automount successfully stopped
s6-rc: info: service legacy-cont-init: stopping
s6-rc: info: service legacy-cont-init successfully stopped
s6-rc: info: service fix-attrs: stopping
s6-rc: info: service base-addon-log-level: stopping
s6-rc: info: service fix-attrs successfully stopped
s6-rc: info: service base-addon-log-level successfully stopped
s6-rc: info: service base-addon-banner: stopping
s6-rc: info: service base-addon-banner successfully stopped
s6-rc: info: service s6rc-oneshot-runner: stopping
s6-rc: info: service s6rc-oneshot-runner successfully stopped

Addon Config

workgroup: WORKGROUP
username: homeassistant
allow_hosts:
  - 10.0.0.0/8
  - 172.16.0.0/12
  - 192.168.0.0/16
  - 169.254.0.0/16
  - fe80::/10
  - fc00::/7
  - 2a02:2f07/10
automount: true
moredisks: []
mountoptions:
  - nosuid
  - relatime
  - noexec
available_disks_log: true
medialibrary:
  enable: true
veto_files:
  - ._*
  - .DS_Store
  - Thumbs.db
  - icon?
  - .Trashes
compatibility_mode: true
recyle_bin_enabled: false
wsdd2: true
mqtt_nexgen_entities: true
autodiscovery: {}
other_users:
  - username: luzer
    password: no more passwords
acl:
  - share: media
    disabled: false
    users:
      - luzer
interfaces: []
password: ************
enable_smart: true
hdd_idle_seconds: 30
bind_all_interfaces: true

Architecture

amd64

OS

HaOS

[dianlight]

Resolved in beta channe with PR: dianlight/hassio-addons-beta#12