search

dianna-ai / dianna

Deep Insight And Neural Network Analysis
https://dianna.readthedocs.io
Apache License 2.0
44 stars 13 forks source link

738 text lime in dashboard returns an error #799

Closed laurasootes closed 2 weeks ago

laurasootes commented 3 weeks ago

This PR fixes #738

Lime runs into an error because of a typo in the variable name -> rand_state instead of random_state. Additionally lime timeseries does not have this variable, which also returns an error, since the random_state variable is used in all LIME methods. Although random_state is not used in lime timeseries, adding the variable to the class fixes the issue.

Edit: Added tests for dashboard text, image, and timeseries for LIME and KernelSHAP to complete the dashboard tests. It turned out that the dashboard was actually not working for images with KernelSHAP. I made changes in dashboard/_models_image.py to do this, but I am not sure of the changes are 100% correct. Can someone please check @cwmeijer @loostrum maybe?

laurasootes commented 2 weeks ago

I added tests for images, text and timeseries, but encountered a problem with images KernelSHAP, see my updated PR comment above