search

dianna-ai / dianna

Deep Insight And Neural Network Analysis
https://dianna.readthedocs.io
Apache License 2.0
48 stars 13 forks source link

Tensorflow lower limit conflicts #826

Open egpbos opened 4 months ago

egpbos commented 4 months ago

Due to the lower limit on the Tensorflow version that dianna uses, I cannot use dianna on my particular GPU setup with its particular CUDA version installed (DAS6 @ VU). This makes me sad :( Please unsad me!

It seems the change was introduced in this PR: https://github.com/dianna-ai/dianna/pull/588. I don't see the change motivated there, but perhaps someone remembers whether there was a valid reason.

Can this be reverted? In fact, is a lower limit on Tensorflow needed at all?

egpbos commented 4 months ago

I see that the lower limit of 2.11 was introduced here https://github.com/dianna-ai/dianna/commit/bb42372bcf2e65376bd608cb60f08f96e39f8da6, which does seem functional, so can we revert to 2.11?

egpbos commented 4 months ago

On closer look, it seems like the actual issue that bb42372 resolved was #434.

The lack of dependencies specified for tensorflow-probability are the root cause then. However, they do in fact specify the minimum required tensorflow version via an extra in setup.py. This means we can drop the upper limit and replace our dependency with tensorflow-probability[tf].

I'll make a PR for this to demonstrate (and check whether it actually works 😄).

egpbos commented 4 months ago

Also related: #727