search

diaspora / diaspora-project-site

Code for the Diaspora project site.
https://diasporafoundation.org/
Other
48 stars 41 forks source link

Update discussion links and description of notification icon (satellite -> bell) #101

Closed goobertron closed 7 years ago

goobertron commented 7 years ago

Just a one-word change. I missed this during the last round of updating!

goobertron commented 7 years ago

Changed Google groups links to Discourse to fix #102. Also changed external links in application.rb from http:// to https://

goobertron commented 7 years ago

The 'General' and 'Development' categories mirror those to IRC channels which appear to the left of these in the footer.

At the moment, there is:

Left-hand column

Middle column

Right-hand column

Are all of these still useful here? Should we remove or replace any? Should we add any new links here?

There are currently three lines in the left-hand column, so there are spaces to add one more entry to the middle (currently IRC) and right (currently Discourse) columns if needed.

SuperTux88 commented 7 years ago

The 'General' and 'Development' categories mirror those to IRC channels which appear to the left of these in the footer.

We have still 2 IRC channels, but the mailinglists are now combined in one discourse instance. And I don't know if we should link to the categories in discourse, because there are many categories, and we can't link to all of them. But I want to at least show that there is also support available on discourse now.

There are currently three lines in the left-hand column, so there are spaces to add one more entry to the middle (currently IRC) and right (currently Discourse) columns if needed.

Maybe we can move some entries around, so that there are two in every column. What about this?

Left-hand column

Middle column

Right-hand column

goobertron commented 7 years ago

That looks fine to me, and I see it's fine with Dennis as well. I'll implement that.

goobertron commented 7 years ago

Awaiting review.

Flaburgan commented 7 years ago

Another possibility would be to keep the first column, to move "Discussion & Support" to the second one, and to add links to the federation protocol on the last one (like, github, gem, documentation).

goobertron commented 7 years ago

As the layout in the latest push has approval from @SuperTux88, @denschub and me, I'm happy to keep it that way! We can always make further changes in later PRs.

@denschub, anything else I need to do to this before it is merged?

SuperTux88 commented 7 years ago

Yes, I think the current footer is OK. Maybe we can add a link to https://diaspora.github.io/diaspora_federation/ somewhere (I don't know if it needs to be in the footer), and I don't think we need more links for the federation. But for now I think this PR is good.

goobertron commented 7 years ago

Yeh, I think the federation gem might be a bit specialist to be in the footer or on the home page.

We could change the Codebase link to http://github.com/diaspora/ so that all repos are displayed (including the federation gem and the project site repo). Unless anyone feels strongly, I'm inclined to leave things as they are in the PR.

SuperTux88 commented 7 years ago

That might be an idea, especially with the pinned repos at the top. :)

goobertron commented 7 years ago

Done!

goobertron commented 7 years ago

I'm pretty sure this is ready for merging now.

SuperTux88 commented 7 years ago

Since I have permissions for this repo now ( 🎉 ), I merged and deployed this, thanks ❤️

goobertron commented 7 years ago

Thank you!