search

diaspora / diaspora-project-site

Code for the Diaspora project site.
https://diasporafoundation.org/
Other
48 stars 41 forks source link

Repair all broken strings in UI #95

Closed goobertron closed 7 years ago

goobertron commented 7 years ago

This fixes https://github.com/diaspora/diaspora-project-site/issues/89 and https://github.com/diaspora/diaspora-project-site/issues/91.

@Flaburgan, please would you pull this into your local installation and check that I haven't missed anything? You could compare with https://github.com/goobertron/diaspora-project-site/commit/beafa22721f155442bc2f9563cce5c9cfe9a4acd to make sure I haven't done anything silly. I've checked myself, and I'm fairly sure that everything is as it should be, but my concentration isn't 100% at the moment so I'd really appreciate your eyes over this.

denschub commented 7 years ago

❤️

Flaburgan commented 7 years ago

Thank you very much for doing that. I'm going to review it on Friday midday.

Flaburgan commented 7 years ago

So I did a quick review.

It looks like you missed some strings on the getting_started/sharing page.

Top Buttons Top Buttons Ex1 Top Buttons List1 Top Buttons List2 Top Buttons List3 Top Buttons List4 Top Buttons List5 Top Buttons List6 Top Buttons List7 Top Buttons List8 Top Buttons List9

There is also the Poll Ex one and the Text formatting, Links Ex and Images Ex. Interact Ex3, Post Icons, Notifications Ex and Report Ex.

Again, thanks for working on this.

goobertron commented 7 years ago

Whoops! Thank you for spotting that. How did I miss such a big mistake? Anyway, all are there now. Revise commit now pushed. Thanks for reviewing it carefully!

Flaburgan commented 7 years ago

@denschub if you have some time to merge this and push to prod it would be awesome <3

denschub commented 7 years ago

Done!